Add/create theme variation to site editor interface #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbking
force-pushed
the
add/create-theme-variation
branch
from
1a52998
to
788efdb
Compare
mikachan
approved these changes
Apr 2, 2024
madhusudhand
force-pushed
the
add/create-theme-variation
branch
from
788efdb
to
36fe5ce
Compare
madhusudhand
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529
Adds ability to create a theme variation from the site editor interface:
To Test:
Make changes to Global Styles using the Global Styles interface. (Do not persist those changes to your theme).
Save a theme variation using the new interface.
Ensure that the name given the variation (using the form above it) is reflected in the JSON.
Ensure that the styles changed are present in the JSON.
Ensure that the style variation is available to the user in the Global Styles panel.
Should not be merged until #522 lands