add deprecation notice in theme export admin screen #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
force-pushed
the
add-theme-notice
branch
from
b1f38c7
to
7068b27
Compare
mikachan
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
This looks good to me and I like the idea of adding a deprecation notice to this page in the next release. This gives users a more gradual transition to the options in the editor.
I'd like to see what @vcanales thinks but otherwise I'm happy to bring this in.
vcanales
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a notice about removal of theme export options from admin screen.