Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing build step to deploy workflow #546

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add missing build step to deploy workflow #546

merged 1 commit into from
Apr 9, 2024

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Apr 9, 2024 •
edited
Loading

Deploy workflow was missing the npm build steps.

@vcanales vcanales requested a review from pbking April 9, 2024 15:35
pbking
pbking approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Need that step. :)

@pbking pbking merged commit 99915dc into trunk Apr 9, 2024
2 checks passed
@pbking pbking deleted the fix-deploy-step branch April 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbking pbking pbking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vcanales @pbking