Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme, remove test files from release build #548

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Apr 9, 2024

Removes reference to font management still present in the readme file.
Also removes test-related files from release builds.

@vcanales vcanales requested a review from pbking April 9, 2024 16:36
@vcanales vcanales force-pushed the update-readme-remove-font-management branch from a618eff to bc64d15 Compare April 9, 2024 16:38
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! I think there are a few other remaining references to fonts too:

readme.txt:

  • line 27
  • line 30 - mention of fonts

readme.md:

  • lines 13 & 14
  • lines from 56 - 65 ("Embed Google Fonts or local font files")
  • lines 76 & 77
  • line 79 - this section mentions editing fonts via the plugin

@vcanales
Copy link
Member Author

vcanales commented Apr 9, 2024

Good spot! I think there are a few other remaining references to fonts too:

Thanks! I've removed those as well. I added a deprecation notice on the readme.md file as well.

@vcanales vcanales changed the title Update readme, removing reference to fonts Update readme, remove test files from release build Apr 9, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vcanales and others added 2 commits April 9, 2024 13:22
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vcanales vcanales merged commit c6492f7 into trunk Apr 9, 2024
2 checks passed
@vcanales vcanales deleted the update-readme-remove-font-management branch April 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants