Fix hardcoded wp-admin URLs #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Apr 21, 2024
Comment on lines
-250
to
+253
| alt="WordPress 6.5 Font Library" | ||
| alt={ __( | ||
| 'WordPress 6.5 Font Library', | ||
| 'create-block-theme' | ||
| ) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #561
This PR fixes the following two links so that they work correctly in an environment installed in a subdirectory.
http://localhost:8888/wp-admin/themes.php?page=manage-fonts
http://localhost:8888/wp-admin/themes.php?page=create-block-theme
Testing Instructions
It's a bit complicated, but in order to actually test this PR, you'll need an environment with WordPress installed in a subdirectory. There are several ways to do this, but this handbook page will help you set up your environment.