Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process group background image when saving theme #586

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

pbking
Copy link
Contributor

@pbking pbking commented Apr 24, 2024

When saving a theme with "localize images" selected the background image of a group block should be included.

To test:

  • Edit a template in a theme and add a group block
  • Add a background image to that group block
  • Save your changes (to the user space)
  • Using CBT save your changes (to the theme). Make sure "Localize Images" is selected
  • Observe our theme files. Note that the template that was edited uses a pattern, the pattern has the group block with an image referenced from the /assets folder
  • Export the theme. Note that the template, pattern and assets are correct

@vcanales
Copy link
Member

vcanales commented Apr 24, 2024

After following the test steps provided, I somehow end up with an error when trying to export the zip file.

POST http://localhost:8888/index.php?rest_route=%2Fcreate-block-theme%2Fv1%2Fexport&_locale=user 500 (Internal Server Error)

As far as I can. tell, rest_route has no value assigned to it on that URL. Not sure how it's related, but going back to trunk everything works normally. Any ideas?

image

@pbking pbking force-pushed the fix/group-background-image-saving branch from cef5535 to 607f28a Compare April 25, 2024 00:29
@pbking
Copy link
Contributor Author

pbking commented Apr 25, 2024

I suspect the error was the same as was fixed here.

That fix was merged into trunk, but this work was branched from trunk before it was merged. I have rebased trunk and expect it will work as expected now.

Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected 👍

@pbking pbking merged commit d737bba into trunk Apr 25, 2024
2 checks passed
@pbking pbking deleted the fix/group-background-image-saving branch April 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants