Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move screenshots to display in wordpress.org plugin page #598

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Move screenshots image files location.

Why?

To display in wordpress.org plugin page.

Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a hard time finding why this was necessary; for context, I believe it's because the GitHub action we use to deploy the plugin to dotorg handles the movement of assets, and it uses the .wordpress-org directory to do so. This is documented here: https://github.com/10up/action-wordpress-plugin-asset-update?tab=readme-ov-file#optional-environment-variables

@matiasbenedetto matiasbenedetto merged commit 352a397 into trunk Apr 26, 2024
2 checks passed
@matiasbenedetto matiasbenedetto deleted the update/move-screenshots branch April 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants