Adds an endpoints that returns a list of font families used by a theme #648
Conversation
…e, including their style variants
admin/create-theme/theme-fonts.php
Outdated
|
|
||
| return $font_families; |
There was a problem hiding this comment.
If we drop something like this into this get_all_fonts function then we can eliminate the 'make theme absolute' function (which is really just string/array checks and a str_replace), eliminate the iteration logic in the api class and always ensure that the src attributes are arrays.
// ensure that src is an array
foreach( $font_families as &$font_family ) {
if ( isset( $font_family['fontFace'] ) ) {
foreach( $font_family['fontFace'] as &$font_face ) {
if ( ! is_array( $font_face['src'] ) ) {
$font_face['src'] = array( $font_face['src'] );
}
// make the src urls absolute
if ( $absolute_src ) {
foreach( $font_face['src'] as &$font_face_src ) {
if ( str_starts_with( $font_face_src, 'file:./' ) ) {
return str_replace( 'file:./', get_stylesheet_directory_uri() . '/', $font_face_src );
}
}
}
}
}
}There was a problem hiding this comment.
If we drop something like this into this get_all_fonts function, we can eliminate the 'make theme absolute' .
I don't see the need to grow one function by absorbing the same code as another. The separation of concerns is clear. What's the benefit?
ensure that the src attributes are arrays
Why should we ensure that?
There was a problem hiding this comment.
I see that you have already moved half of it in from the API class; that was most of the concern and that's enough that you can resolve this discussion if you want.
But I find the make_theme_font_src_absolute function overly complicated when the same could be completed using fewer, easier to understand lines in the get_all_fonts function. The make_theme_font_src_absolute logic is not re-used.
By ensuring that the response to the API always returns the src in the form of an array the client won't have to execute the "is it a string or an array" check when it works with this data; it will always be an array (and makes the processing of that easier here too).
Something that is different in this endpoint than in |
I think the frontend could cobble together the data using that and other APIs but I agree it's nice to have everything packaged nicely and ready-to-go with this one API addition. |
|
I added some unit tests and merged trunk to fix some conflicts. I think this is good to bring in and focus on the last branch. |
What?
/wp-json/create-block-theme/v1/font-families) that returns a list of font families used by a theme, including their style variants.Why?
Example:
With TT4 theme activated you should get an answer like this from the endpoint
/wp-json/create-block-theme/v1/font-families:{ "status":"SUCCESS", "message":"Font Families retrieved.", "data":[ { "fontFace":[ { "fontFamily":"Inter", "fontStretch":"normal", "fontStyle":"normal", "fontWeight":"300 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/inter\/Inter-VariableFont_slnt,wght.woff2" ] } ], "fontFamily":"\"Inter\", sans-serif", "name":"Inter", "slug":"body" }, { "fontFace":[ { "fontFamily":"Cardo", "fontStyle":"normal", "fontWeight":"400", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_normal_400.woff2" ] }, { "fontFamily":"Cardo", "fontStyle":"italic", "fontWeight":"400", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_italic_400.woff2" ] }, { "fontFamily":"Cardo", "fontStyle":"normal", "fontWeight":"700", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_normal_700.woff2" ] } ], "fontFamily":"Cardo", "name":"Cardo", "slug":"heading" }, { "fontFamily":"-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Cantarell, Ubuntu, roboto, noto, arial, sans-serif", "name":"System Sans-serif", "slug":"system-sans-serif" }, { "fontFamily":"Iowan Old Style, Apple Garamond, Baskerville, Times New Roman, Droid Serif, Times, Source Serif Pro, serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol", "name":"System Serif", "slug":"system-serif" }, { "fontFace":[ { "fontFamily":"Instrument Sans", "fontStyle":"normal", "fontWeight":"400 700", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/instrument-sans\/InstrumentSans-VariableFont_wdth,wght.woff2" ] }, { "fontFamily":"Instrument Sans", "fontStyle":"italic", "fontWeight":"400 700", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/instrument-sans\/InstrumentSans-Italic-VariableFont_wdth,wght.woff2" ] } ], "fontFamily":"\"Instrument Sans\", sans-serif", "name":"Instrument Sans", "slug":"body" }, { "fontFace":[ { "fontFamily":"Jost", "fontStyle":"normal", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-VariableFont_wght.woff2" ] }, { "fontFamily":"Jost", "fontStyle":"italic", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-Italic-VariableFont_wght.woff2" ] } ], "fontFamily":"\"Jost\", sans-serif", "name":"Jost", "slug":"heading" }, { "fontFamily":"-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Cantarell, Ubuntu, roboto, noto, arial, sans-serif", "name":"System Sans-serif", "slug":"system-sans-serif" }, { "fontFamily":"Iowan Old Style, Apple Garamond, Baskerville, Times New Roman, Droid Serif, Times, Source Serif Pro, serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol", "name":"System Serif", "slug":"system-serif" }, { "fontFace":[ { "fontFamily":"Inter", "fontStretch":"normal", "fontStyle":"normal", "fontWeight":"300 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/inter\/Inter-VariableFont_slnt,wght.woff2" ] } ], "fontFamily":"\"Inter\", sans-serif", "name":"Inter", "slug":"heading" }, { "fontFace":[ { "fontFamily":"Cardo", "fontStyle":"normal", "fontWeight":"400", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_normal_400.woff2" ] }, { "fontFamily":"Cardo", "fontStyle":"italic", "fontWeight":"400", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_italic_400.woff2" ] }, { "fontFamily":"Cardo", "fontStyle":"normal", "fontWeight":"700", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_normal_700.woff2" ] } ], "fontFamily":"Cardo", "name":"Cardo", "slug":"body" }, { "fontFamily":"-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Cantarell, Ubuntu, roboto, noto, arial, sans-serif", "name":"System Sans-serif", "slug":"system-sans-serif" }, { "fontFamily":"Iowan Old Style, Apple Garamond, Baskerville, Times New Roman, Droid Serif, Times, Source Serif Pro, serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol", "name":"System Serif", "slug":"system-serif" }, { "fontFace":[ { "fontFamily":"Inter", "fontStretch":"normal", "fontStyle":"normal", "fontWeight":"300 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/inter\/Inter-VariableFont_slnt,wght.woff2" ] } ], "fontFamily":"\"Inter\", sans-serif", "name":"Inter", "slug":"heading" }, { "fontFace":[ { "fontFamily":"Jost", "fontStyle":"normal", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-VariableFont_wght.woff2" ] }, { "fontFamily":"Jost", "fontStyle":"italic", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-Italic-VariableFont_wght.woff2" ] } ], "fontFamily":"\"Jost\", sans-serif", "name":"Jost", "slug":"body" }, { "fontFamily":"-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Cantarell, Ubuntu, roboto, noto, arial, sans-serif", "name":"System Sans-serif", "slug":"system-sans-serif" }, { "fontFamily":"Iowan Old Style, Apple Garamond, Baskerville, Times New Roman, Droid Serif, Times, Source Serif Pro, serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol", "name":"System Serif", "slug":"system-serif" }, { "fontFace":[ { "fontFamily":"Cardo", "fontStyle":"normal", "fontWeight":"400", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_normal_400.woff2" ] }, { "fontFamily":"Cardo", "fontStyle":"italic", "fontWeight":"400", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_italic_400.woff2" ] }, { "fontFamily":"Cardo", "fontStyle":"normal", "fontWeight":"700", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/cardo\/cardo_normal_700.woff2" ] } ], "fontFamily":"Cardo", "name":"Cardo", "slug":"body" }, { "fontFace":[ { "fontFamily":"Jost", "fontStyle":"normal", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-VariableFont_wght.woff2" ] }, { "fontFamily":"Jost", "fontStyle":"italic", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-Italic-VariableFont_wght.woff2" ] } ], "fontFamily":"\"Jost\", sans-serif", "name":"Jost", "slug":"heading" }, { "fontFamily":"-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Cantarell, Ubuntu, roboto, noto, arial, sans-serif", "name":"System Sans-serif", "slug":"system-sans-serif" }, { "fontFamily":"Iowan Old Style, Apple Garamond, Baskerville, Times New Roman, Droid Serif, Times, Source Serif Pro, serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol", "name":"System Serif", "slug":"system-serif" }, { "fontFace":[ { "fontFamily":"Instrument Sans", "fontStyle":"normal", "fontWeight":"400 700", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/instrument-sans\/InstrumentSans-VariableFont_wdth,wght.woff2" ] }, { "fontFamily":"Instrument Sans", "fontStyle":"italic", "fontWeight":"400 700", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/instrument-sans\/InstrumentSans-Italic-VariableFont_wdth,wght.woff2" ] } ], "fontFamily":"\"Instrument Sans\", sans-serif", "name":"Instrument Sans", "slug":"heading" }, { "fontFace":[ { "fontFamily":"Jost", "fontStyle":"normal", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-VariableFont_wght.woff2" ] }, { "fontFamily":"Jost", "fontStyle":"italic", "fontWeight":"100 900", "src":[ "http:\/\/localhost\/wp1\/wp-content\/themes\/twentytwentyfour\/assets\/fonts\/jost\/Jost-Italic-VariableFont_wght.woff2" ] } ], "fontFamily":"\"Jost\", sans-serif", "name":"Jost", "slug":"body" }, { "fontFamily":"-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Cantarell, Ubuntu, roboto, noto, arial, sans-serif", "name":"System Sans-serif", "slug":"system-sans-serif" }, { "fontFamily":"Iowan Old Style, Apple Garamond, Baskerville, Times New Roman, Droid Serif, Times, Source Serif Pro, serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol", "name":"System Serif", "slug":"system-serif" } ] }