Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Add focusable=false to the generated SVG markup (needed for Gutenberg) #224

Closed
afercia opened this issue Aug 29, 2017 · 7 comments
Closed

Add focusable=false to the generated SVG markup (needed for Gutenberg) #224

afercia opened this issue Aug 29, 2017 · 7 comments

Comments

@afercia
Copy link

afercia commented Aug 29, 2017

Hello everyone. In Gutenberg, we've just merged a fix for an IE 11 bug, see WordPress/gutenberg#2590

More details on the PR and the related issue WordPress/gutenberg#1578

The fix is as simple as adding focusable="false" to prevent IE 11 giving focus to the icons.

I guess this fix should be ported here too 🙂
@field2
Copy link
Contributor

field2 commented Aug 29, 2017

Which file needs to be edited? I'm trying to figure out where focusable="false" goes...

@afercia
Copy link
Author

afercia commented Aug 29, 2017

At the end of the react/index.jsx file?

@field2
Copy link
Contributor

field2 commented Sep 5, 2017

This was fixed in a previous PR. Should be all set...

@field2 field2 closed this as completed Sep 5, 2017
@afercia
Copy link
Author

afercia commented Sep 5, 2017

@field2 hi, unfortunately seems the following PR removed it: https://github.com/WordPress/dashicons/pull/226/files

there's no focusable="true" on master

@afercia
Copy link
Author

afercia commented Sep 7, 2017

Ping 🙂 This issue should be reopened.

@field2 field2 reopened this Sep 7, 2017
@field2
Copy link
Contributor

field2 commented Sep 7, 2017

OK, added it again. Please review and make sure everything's up to date.

@afercia
Copy link
Author

afercia commented Sep 7, 2017

Thx! looks good!

@field2 field2 closed this as completed Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@field2 @afercia