Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer 11: all the SVG icons are focusable #1578

Closed
afercia opened this issue Jun 29, 2017 · 11 comments
Closed

Internet Explorer 11: all the SVG icons are focusable #1578

afercia opened this issue Jun 29, 2017 · 11 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] High Used to indicate top priority items that need quick attention
Milestone

Comments

@afercia
Copy link
Contributor

afercia commented Jun 29, 2017

IE 11 suffers from a bug where all SVG icons inside focusable elements default to focusable=”true”. As a consequence, both the wrapper focusable element and the inner SVG get focus and create a tab stop.

This is new to me (not a great SVG expert here) but seems to be a well known bug. More details, for example, here: http://simplyaccessible.com/article/7-solutions-svgs/#acc-heading-4

I've reproduced this behavior testing with IE 11 on all the controls that use SVG icons, for example the ones highlighted in the screenshot below:

screenshot 116

This is very annoying because, when using a keyboard, users have to tab twice to navigate content every time they encounter a control with a SVG icon.

I haven't been able to reproduce in Edge, where everything seems to work fine, but some more testing would be nice.

Seems the recommended fix is to add focusable="false" to the SVGs, but maybe worth researching if there are other, less intrusive, fixes.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 29, 2017
@jasmussen
Copy link
Contributor

Can reproduce this in IE11 :(

If we do need to add any properties to these SVGs, we might want to do it upstream in the dashicons repo.

@dpersing
Copy link

dpersing commented Jul 6, 2017

@afercia @jasmussen So glad our article was helpful!

@jasmussen jasmussen added the Browser Issues Issues or PRs that are related to browser specific problems label Aug 18, 2017
@afercia afercia added the [Priority] High Used to indicate top priority items that need quick attention label Aug 29, 2017
@afercia
Copy link
Contributor Author

afercia commented Aug 29, 2017

Marking with the high priority label to indicate it's an a11y priority. This should be definitely be fixed, as the keyboard navigation experience is subpar for IE 11 users.

@samikeijonen
Copy link
Contributor

So it seems focusable="false" in SVG would fix this. From my understanding all the SVG markup can be updated in one place. I can find out.

@samikeijonen
Copy link
Contributor

If I'm correct the SVG markup happens in here.

@youknowriad
Copy link
Contributor

This seems already fixed for me. Am I missing something?

@afercia
Copy link
Contributor Author

afercia commented Oct 5, 2017

I think it was just waiting for the fixes to be ported to the dashicon repo too.

@jasmussen
Copy link
Contributor

I think it was just waiting for the fixes to be ported to the dashicon repo too.

I'll take a look.

@samikeijonen
Copy link
Contributor

They should be in dashicon repo too, at least I have reported in there also.

@youknowriad
Copy link
Contributor

youknowriad commented Oct 5, 2017

I just checked and I see the "focusable=false" in the dashicon repo

https://github.com/WordPress/dashicons/blob/master/react/index.jsx#L841

@jasmussen
Copy link
Contributor

Cool, this sounds closable then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Development

No branches or pull requests

6 participants