-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested styles #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Missing whitespace.
style.css
Outdated
@@ -819,3 +819,7 @@ object { | |||
.wp-block-embed { | |||
text-align: center; | |||
} | |||
|
|||
.wp-block-embed .twitter-tweet-rendered { | |||
margin:0 auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Missing whitespace between property and value?
|
||
.wp-block-button.aligncenter { | ||
display: block; | ||
margin:0 auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Missing whitespace between property and value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, I missed that 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More indentation here than in the rest of the stylesheet — maybe swap out to match the rest of the stylesheet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the demo, I don't think this should be full-width.
.wp-block-button.aligncenter { | ||
display: block; | ||
margin:0 auto; | ||
text-align: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More indentation here than in the rest of the stylesheet — maybe swap out to match the rest of the stylesheet?
} | ||
|
||
.wp-block-embed .twitter-tweet-rendered { | ||
margin:0 auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a space between margin
and 0
@@ -30,7 +33,13 @@ ol, | |||
.wp-block-cover-text.alignfull, | |||
.wp-block-image.alignfull, | |||
.wp-block-gallery.alignfull, | |||
..wp-block-text-columns.alignfull{ | |||
.wp-block-text-columns.alignfull{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a space between .alignfull
and {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor spacing issues, but otherwise looking good — if you patch those up, and fix up the button width, I think it'll be good to go.
|
||
.wp-block-button.aligncenter { | ||
display: block; | ||
margin:0 auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the demo, I don't think this should be full-width.
Can you redo this PR with the suggestions in place please @AaronRutley? Note, there have been updates to the theme so make sure you grab the latest and resolve conflicts. Thanks! |
Closing as we have conflicts and have split this from the .org site now. |
I've suggested some styles to improve the 'gutenberg-demo' post.