Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Date: Stop exposing Moment object on public interface #10007

Closed
aduth opened this issue Sep 18, 2018 · 1 comment
Closed

Packages: Date: Stop exposing Moment object on public interface #10007

aduth opened this issue Sep 18, 2018 · 1 comment
Labels
[Package] Date /packages/date [Type] Breaking Change For PRs that introduce a change that will break existing functionality [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented Sep 18, 2018

Discussed today in the Slack #core-js Weekly Chat (link requires registration)
Related: #9485

The public interface of all of our modules should serve as a contract to which we commit to forward compatibility. For this reason, we should limit surface area where possible, notably in implementation detail of underlying dependencies.

Task: For the packages/date module, we should remove all exposed methods which commit us to Moment.js . If necessary, this may require the addition of substitute interfaces. These should be implemented in a fashion non-specific to Moment and which are designed in a way that we are generally comfortable to committing to as a contract.

Extra Credit: Improve documentation of the packages/date module to document available public functions.

@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Breaking Change For PRs that introduce a change that will break existing functionality [Package] Date /packages/date labels Sep 18, 2018
@aduth
Copy link
Member Author

aduth commented Nov 15, 2018

Closed by #11418 (cc @youknowriad)

@aduth aduth closed this as completed Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Date /packages/date [Type] Breaking Change For PRs that introduce a change that will break existing functionality [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

1 participant