New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed block/floated embed block audit #10440

Open
jasmussen opened this Issue Oct 9, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@jasmussen
Contributor

jasmussen commented Oct 9, 2018

In #10437 we discovered an issue with embedding Instagram posts.

The issue was that when we float an embed, we set a minimum and a maximum width on the floated embed, because the embed itself does not necessarily have a specific intrinsic width we can work with. In the case of Instagram, the max-width we set (290px) was smaller than the minimum width supported by Instagram embeds (326px).

Following this, we should do an audit on every embed block, floated or otherwise, and verify that they are not cropped at any time.

@gziolo

This comment has been minimized.

Member

gziolo commented Oct 16, 2018

@jasmussen is there any more work left? I see one PR merged. Can we move to 4.2?

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Oct 16, 2018

Yes okay to move. But would be good to do a thorough test sooner rather than later 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment