Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Toolbar interferes with wide alignment drag handle #12601

Closed
aduth opened this issue Dec 4, 2018 · 4 comments
Closed

Editor: Toolbar interferes with wide alignment drag handle #12601

aduth opened this issue Dec 4, 2018 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Dec 4, 2018

Steps to Reproduce:

Prerequisite: Activate a theme which supports wide alignment (e.g. Twentynineteen)

  1. Navigate to Posts > Add New
  2. (If not already, deactivate the Menu > "Top Toolbar" option)
  3. Insert an image block
  4. Choose an image
  5. Change alignment to Wide or Full
  6. Insert at least one other block
  7. Try to drag the wide image block to rearrange

Expected result:

Drag and drop works. The block should either not become selected upon click on the drag handle, or the selection should only occur after mouseup.

Actual result:

When mousedown occurs on the drag handle, the appearance of the Toolbar conflicts with the drag action and terminates it prematurely.

Workarounds:

  1. Use "Top Toolbar" mode (found under Menu)
  2. Rearrange block using the "Move Up" and "Move Down" options
@aduth aduth added the [Feature] Blocks Overall functionality of blocks label Dec 4, 2018
@designsimply
Copy link
Member

Previously: #7914

@designsimply
Copy link
Member

Tested and confirmed using WordPress 4.9.8 and Gutenberg 4.6.1 master @ 46f789a5c on Firefox 63.0.3 on macOS 10.13.6.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Dec 4, 2018
@lumpysimon
Copy link

lumpysimon commented Dec 6, 2018

I'm seeing this in 5.0-RC3-43969 in latest versions of Chrome and Firefox, MacOS 10.13.

I would describe it as a bug, not an enhancement, as most users (myself included) would not know to switch to Top Toolbar mode.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Dec 6, 2018
@aduth
Copy link
Member Author

aduth commented Apr 22, 2019

I can no longer reproduce this. In wide alignment, the drag handle is shown to the left of the toolbar and no longer overlaps when the viewport is wide enough. On smaller viewports, there is no drag handle option.

@aduth aduth closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants