Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some E2E tests fail on the Docker environment #14732

Closed
6 tasks done
ashwin-pc opened this issue Mar 31, 2019 · 4 comments
Closed
6 tasks done

Some E2E tests fail on the Docker environment #14732

ashwin-pc opened this issue Mar 31, 2019 · 4 comments
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling

Comments

@ashwin-pc
Copy link
Contributor

ashwin-pc commented Mar 31, 2019

Describe the bug
On a fresh clone of the Gutenberg repo on a new docker instance, some of the e2e tests fail.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the Gutenberg repo
  2. Setup a new Docker environment
  3. Run ./bin/setup-local-env.sh
  4. Run npm run build
  5. Test using npm run test-e2e
  6. Some tests/snapshots fail (see attached screenshot below)

Tests Failing

  • Reusable Blocks › can be created from multiselection
    Error: waiting for selector "button[aria-label="More options"]" failed: timeout 30000ms exceeded
  • Reusable Blocks › multi-selection reusable block can be converted back to regular blocks
    Error: No node found for selector: button[aria-label="Multi-selection reusable block"]
  • (Snapshot) RichText › should apply formatting with access shortcut
    Expected - <p><s>test</s></p>
    Received + <p>test</p>
  • (Snapshot) RichText › should apply formatting with primary shortcut
    Expected - <p><s>test</s></p>
    Received + <p>test</p>
  • Multi-block selection › Should select/unselect multiple blocks
    Expected: StringContaining "is-multi-selected"
    Received: "wp-block editor-block-list__block block-editor-block-list__block is-selected"
  • Multi-block selection › should speak() number of blocks selected with multi-block selection

Expected behavior
All test should have passed.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS Mojave
  • Browser Chrome
  • Version 73.0.3683.86 (Official Build) (64-bit)
@swissspidy swissspidy added [Type] Build Tooling Issues or PRs related to build tooling [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 2, 2019
@gziolo gziolo added the [Type] Bug An existing feature does not function as intended label Apr 2, 2019
@gziolo
Copy link
Member

gziolo commented Apr 2, 2019

@aduth - it all looks similar to the Puppeteer’s bug with select all shortcut behavior. I’m wondering if there are other issues present.

@aduth
Copy link
Member

aduth commented Apr 2, 2019

Yes, it's highly likely these are all related to the same Cmd+A emulation issue under consideration for resolution by #14243 (the underlying issue described at puppeteer/puppeteer#1313 )

@ashwin-pc
Copy link
Contributor Author

@gziolo The PR #14243 Has since fixed all these failures and in the commit (454011e) in which the PR was merged in passes all the test cases. But the latest master brach fails one test not in this list. Do i raise a new issue on it or update this Issue by adding it here and marking the resolved ones as checked.

@gziolo
Copy link
Member

gziolo commented Apr 5, 2019

@ashwin-pc, thank you for confirmation. Let's close this one and report the new issue independently. I did a quick check of open issues labeled with Automated Testing and it looks like we don't have any reports of known tests that fail locally.

@gziolo gziolo closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

No branches or pull requests

4 participants