Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient contrast on empty field borders #15275

Closed
karlgroves opened this issue Apr 30, 2019 · 4 comments
Closed

Insufficient contrast on empty field borders #15275

karlgroves opened this issue Apr 30, 2019 · 4 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@karlgroves
Copy link

Insufficient contrast on empty field borders

  • Severity: Low
  • Affected Populations:
    • Low-Vision
    • Cognitively
  • Platform(s):
    • All / Universal
  • Components affected:
    • Media Dialog

Issue description

Some interface components in the "Featured Image" modal have
insufficient color contrast for their borders when empty, below the
minimum threshold of 3:1 for interface components:

  • Caption, Alt Text and Description field borders: light-grey (#ddd) on lighter grey (#f3f3f3): 1.35:1

Sufficient color contrast is important for users who have low-vision or
are color-blind, because content with a low contrast ratio may be
difficult or impossible for such users to see.

Issue Code
    .media-frame input[type=email], .media-frame input[type=number], .media-frame input[type=password], .media-frame input[type=search], .media-frame input[type=text], .media-frame input[type=url], .media-frame select, .media-frame textarea {
        ...
        border-width: 1px;
        border-style: solid;
        border-color: #ddd;
    }

Remediation Guidance

Darken the border-color to create a minimum contrast ratio of 3:1.

Recommended Code
    .media-frame input[type=email], .media-frame input[type=number], .media-frame input[type=password], .media-frame input[type=search], .media-frame input[type=text], .media-frame input[type=url], .media-frame select, .media-frame textarea {
        ...
        border-width: 1px;
        border-style: solid;
        border-color: #8f8f8f;
    }

Relevant standards

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-44 in Tenon's report

@gziolo gziolo added the Needs Accessibility Feedback Need input from accessibility label Apr 30, 2019
@aduth aduth added this to To do in Accessibility Audit May 1, 2019
@afercia
Copy link
Contributor

afercia commented May 1, 2019

Worth noting the media modals aren't part of Gutenberg. This issue should be moved to the core Trac under the Media component.

Also, the grey backgrounds #f1f1f1 or #f3f3f3 are used in many other places in WordPress (e.g. Setting Pages, etc.) so I guess it would need some more exploration.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Media Anything that impacts the experience of managing media and removed Needs Accessibility Feedback Need input from accessibility labels May 1, 2019
@melchoyce
Copy link
Contributor

Full report screenshot:

image

@melchoyce melchoyce moved this from To do to Move to Trac in Accessibility Audit May 5, 2019
@gziolo gziolo added the [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. label May 6, 2019
@anevins12
Copy link
Contributor

anevins12 commented May 6, 2019

Moved to Trac: https://core.trac.wordpress.org/ticket/47150

@afercia
Copy link
Contributor

afercia commented May 6, 2019

Closing as moved to Trac.

@afercia afercia closed this as completed May 6, 2019
Accessibility Audit automation moved this from Move to Trac to Closed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
Development

No branches or pull requests

6 participants