Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize SlotFills that use <PanelBody/> to inherit icon property from registerPlugin #16379

Closed
ryanwelcher opened this issue Jul 1, 2019 · 1 comment
Closed

Standardize SlotFills that use <PanelBody/> to inherit icon property from registerPlugin #16379

ryanwelcher opened this issue Jul 1, 2019 · 1 comment
Labels
[Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API

Comments

@ryanwelcher
Copy link
Contributor

ryanwelcher commented Jul 1, 2019 •
edited

Based on the work done in #13361, it now seems to make sense that any SlotFill that uses <PanelBody/> that is added by via registerPlugin() should be able to inherit the icon property.

SlotFills:

PluginPrePublishPanel: #16378
PluginPostPublishPanel: #16383
@swissspidy swissspidy added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API labels Jul 2, 2019
@gziolo gziolo removed the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Oct 10, 2019
@gziolo
Copy link
Member

gziolo commented Oct 20, 2019

Both linked PRs were landed a while ago. This can be closed 🎉

@gziolo gziolo closed this as completed Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gziolo @swissspidy @ryanwelcher