Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for icons in Button blocks #16513

Open
truchot opened this issue Jul 10, 2019 · 5 comments
Open

Add support for icons in Button blocks #16513

truchot opened this issue Jul 10, 2019 · 5 comments
Labels
[Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement.

Comments

@truchot
Copy link
Contributor

truchot commented Jul 10, 2019

In the same idea of #16480, #16481 or #16482 (improvements of button block), maybe we could think about adding a suffix/prefix icon to the button label ?

@swissspidy swissspidy added [Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement. labels Jul 10, 2019
@mtias
Copy link
Member

mtias commented Jul 14, 2019

Agree this would be cool. We probably want to see where #16484 goes first.

@deborah86
Copy link

I am surprised this feature has not been added yet and it hasn't gotten any traction.

@Julianoe
Copy link

Julianoe commented Nov 9, 2022

Has there been some new discussions about icons in Button block recently? The "button with icon" component is very very very common in UIs and has been for years. Currently there is no simple way for users to do that without installing a plugin. Why?

@Jabe64
Copy link

Jabe64 commented Nov 9, 2022

Has there been some new discussions about icons in Button block recently? The "button with icon" component is very very very common in UIs and has been for years. Currently there is no simple way for users to do that without installing a plugin. Why?

As @mtias mentioned #16484 goes first but it's true there hasn't been any update about it for a while 😔

@Julianoe
Copy link

Julianoe commented Nov 9, 2022

Problem is that there is currently no way to do this in other way than inline image, a feature that seems to have been completely forgotten because it's all broken.

Apart from the very obvious bugs (see my just posted issue #45664), the inline image does not behave like an image block that would be contained inside the button which is, I think, the expected behavior. That prevents for example to use .svg images on a WP install where they are reauthorized.

Another way would be to have custom html block inside a button block to include the svg code of an icon.. which is also impossible.

However the Icon Block situation happens to be resolved, I wonder if the two use cases could not be easier ways to implement a "icon button" in the current state of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants