Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Add information about core/data isResolving #17082

Closed
sirreal opened this issue Aug 19, 2019 · 2 comments · Fixed by #52941
Closed

Documentation: Add information about core/data isResolving #17082

sirreal opened this issue Aug 19, 2019 · 2 comments · Fixed by #52941
Assignees
@mburridge
Labels
[Package] Core data /packages/core-data [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers

Comments

@sirreal
Copy link
Member

sirreal commented Aug 19, 2019

The isResolving selector on the core/data store appears to be undocumented. Please consider adding detailed documentation on how to use this selector.
@sirreal sirreal added [Type] Developer Documentation Documentation for developers [Package] Core data /packages/core-data labels Aug 19, 2019
@paaljoachim
Copy link
Contributor

Hey @sirreal Jon

Thanks for creating the issue!
I see no linked PR so I assume that this issue is still valid.

Marcus @mkaz is this something for you to take a closer look at? Thanks.

@xavier-lc
Copy link

Whenever you tackle this, please remember to add hasFinishedResolution and hasStartedResolution too! In the meantime, the documentation on https://unfoldingneurons.com/2020/wordpress-data-store-properties-resolvers is an amazing alternative.

@mburridge mburridge self-assigned this Jul 5, 2023
@mburridge mburridge mentioned this issue Jul 25, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mburridge mburridge

Labels
[Package] Core data /packages/core-data [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds documentation about selectors mburridge/gutenberg
4 participants
@sirreal @paaljoachim @xavier-lc @mburridge