Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

individual column background colours do not fill the entire column #19295

Closed
BinaryMoon opened this issue Dec 22, 2019 · 3 comments
Closed

individual column background colours do not fill the entire column #19295

BinaryMoon opened this issue Dec 22, 2019 · 3 comments
Labels
[Block] Columns Affects the Columns Block [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@BinaryMoon
Copy link

If I add a background colour to a column in the column block then I expect the colour to fill the entire column, but it does not.

For example I want to reproduce this:
medium

So; I add 2 columns. In the first column, I put a header, a title, and then another column block. In the second column I put an image, set the background colour to grey, and set the vertical alignment to center.

This is a screenshot of what I have done in the editor. Note that it works as I expect here:
Screenshot 2019-12-22 at 20 15 58

You can see an example of the problem here (with a slightly different layout):
https://demo.prothemedesign.com/wordpress/gutenberg/2019/12/20/column-background-bug/

In a previous post someone said that they don't think the entire column should change background colour. I disagree.

  1. If I set the background colour for a column to a something else, then (in my mind) it's logical that the entire column would change colour.
  2. In the editor the entire background changes as I would expect (seen in the screenshot above), but on the frontend the layout does not match.
  3. As a designer having the entire background of the change column change colour is more useful than adding a small background around a piece of content.
@ZebulanStanphill ZebulanStanphill added the [Block] Columns Affects the Columns Block label Dec 24, 2019
@talldan talldan added the [Status] Needs More Info Follow-up required in order to be actionable. label Feb 5, 2020
@talldan
Copy link
Contributor

talldan commented Feb 5, 2020

@BinaryMoon How did you set a background color for a column?

There isn't an option to do this with the core columns block. It might be that you're using a plugin for this functionality. If thats is the case you'd need to raise this issue with the plugin developer.

@BinaryMoon
Copy link
Author

I don't know. I assumed it was a core feature. I didn't realise it isn't something core can do. In that case it could be Editorskit (@phpbits?) since that seems to do everything.

I'll close this then since it doesn't seem to be a core thing.

@phpbits
Copy link
Contributor

phpbits commented Feb 5, 2020

@BinaryMoon Seems like align-self behavior of flexbox. And yes, the column background is a feature from EditorsKit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

4 participants