Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual Block Designs #198

Closed
jasmussen opened this issue Mar 7, 2017 · 8 comments
Closed

Individual Block Designs #198

jasmussen opened this issue Mar 7, 2017 · 8 comments

Comments

@jasmussen
Copy link
Contributor

Embed

Empty:

embed-empty

Neutral:

embed-neutral

Selected:

embed-selected

Caption:

embed-caption

Gallery

Neutral:

gallery-neutral

Selected:

gallery-selected

Individual image selected:

gallery-image-selected

Mouse over an image to see the move/drag hand so you can rearrange

Caption:

gallery-caption

Image

Neutral:

image-neutral

Selected:

image-selected

Caption:

image-caption

Text

Neutral:

text-neutral

Selected:

text-selected

Heading

Neutral:

heading-neutral

Selected:

heading-selected

Quote

Neutral:

quote-neutral

Selected:

quote-selected

Citation:

quote-citation

Quote 2

Neutral:

quote 2-neutral

Selected:

quote 2-selected

@ellatrix
Copy link
Member

ellatrix commented Mar 7, 2017

Nice!

@mtias
Copy link
Member

mtias commented Mar 7, 2017

Lovely, thanks.

@shaunandrews
Copy link
Contributor

Digin' it. Nice work.

screen shot 2017-03-07 at 10 40 00 am

There's something about the multiple active items in these menu's that bothers me. There's no separation between groups of items, which makes it hard to grok what "things" are active, and what options are available for those active states. In the image above, for example, its unclear if clicking "B" will "unclick" the quote button.

@jasmussen
Copy link
Contributor Author

There's something about the multiple active items in these menu's that bothers me. There's no separation between groups of items, which makes it hard to grok what "things" are active, and what options are available for those active states. In the image above, for example, its unclear if clicking "B" will "unclick" the quote button.

Solid point, Shaun. I'm always tweaking the Sketch file I have, and in this case the block mockups went out with one where I tried a unified band approach. Seems like we need some separators, or bring back the separate bands approach that are shown in the README mockups.

@mapk
Copy link
Contributor

mapk commented Mar 7, 2017

Seems like we need some separators

I agree. Separators help group selected items visually with what other items can be selected in their stead.

@mapk
Copy link
Contributor

mapk commented Mar 7, 2017

Forgive my ignorance, but is it possible to float gallery blocks?

screen shot 2017-03-07 at 9 01 35 am

@ellatrix
Copy link
Member

ellatrix commented Mar 7, 2017

@mapk I think any object block should be allowed to float. Example: http://www.nytimes.com/projects/2012/snow-fall/#/?part=tunnel-creek

@jasmussen
Copy link
Contributor Author

Closing in favor of all the mockups being shown in the README: https://github.com/WordPress/gutenberg#mockups

We can open individual tickets for individual blocks if issues arise. This sort of meta-ticket just becomes confusing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants