Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning a list to headings creates <br> #2044

Closed
melchoyce opened this issue Jul 26, 2017 · 2 comments
Closed

Turning a list to headings creates <br> #2044

melchoyce opened this issue Jul 26, 2017 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@melchoyce
Copy link
Contributor

melchoyce commented Jul 26, 2017

Feedback from https://wordpress.org/support/topic/great-example-of-why-developers-are-not-ux-experts/:

In content creation I often reformat text, for example changing listed items to headings or switching an H2 to an H3 to create a better structure. Gutenberg did not handle this well at all. Turning a list to headings created some hideous heading block with br’s

@melchoyce melchoyce added the [Type] Bug An existing feature does not function as intended label Jul 26, 2017
@ellatrix
Copy link
Member

Should this even be possible? Imho we should remove the transformation, and let the user use copy paste for this? Or should it detach the first item (or even item that has the caret) and transform it into a heading?

@hedgefield
Copy link

The first thing my mind jumped to was the same idea as @iseulde, selecting the item in question and converting that to a separate heading block, leaving the other list items intact. Although that does present some challenges, such as do we only show the heading buttons when a bit of text is selected? Does the new heading insert above or below the list block? Does the list block split if the item was in the middle?

Maybe a simpler and more logical way would be to still allow the list > heading transformation, but break each list item apart as a separate heading block. I don't know if that's the intended use case, but at least that would make much more sense to me for this transformation than adding all the list items into one heading block, separated by line breaks.

@mtias mtias closed this as completed Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants