Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block picker; retain english terms when translating keywords #21044

Open
simison opened this issue Mar 20, 2020 · 1 comment
Open

Block picker; retain english terms when translating keywords #21044

simison opened this issue Mar 20, 2020 · 1 comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Inserter The main way to insert blocks using the + button in the editing interface Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@simison
Copy link
Member

simison commented Mar 20, 2020

Is your feature request related to a problem? Please describe.

When keywords are translated, English search term gets lost:

keywords: [
	_x( 'columns', 'block search term', 'my-plugin' ),
	_x( 'images', 'block search term', 'my-plugin' ),
	_x( 'photos', 'block search term', 'my-plugin' ),
]

Now if my site is Spanish, I can only find this block using the search term "fotos". That's great, but if I'm maintaining multiple sites or otherwise just being bi-lingual, it would be useful to retain English search terms. I might've also seen a tutorial in one language while my site is in another, and I need to now guess how the English term got translated to my own language.

The same is true with the translated block name.

Describe the solution you'd like
I'd like both "fotos" and "photos" search terms return the block on Spanish site in the above example.

Describe alternatives you've considered

We can do this by duplicating the keywords, but that doesn't seem ideal:

keywords: [
	_x( 'columns', 'block search term', 'my-plugin' ),
	_x( 'images', 'block search term', 'my-plugin' ),
	_x( 'photos', 'block search term', 'my-plugin' ),
	'columns',
	'images',
	'photos',
]

Related to convo at #6633

@simison simison added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Mar 20, 2020
@mtias mtias added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Block API API that allows to express the block paradigm. labels Mar 20, 2020
@ocean90
Copy link
Member

ocean90 commented Mar 21, 2020

Also related: #11370

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Inserter The main way to insert blocks using the + button in the editing interface Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants