Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Japanese environment, only two characters are displayed for the block name that appears when using select mode #21060

Closed
ddryo opened this issue Mar 21, 2020 · 6 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@ddryo
Copy link
Contributor

ddryo commented Mar 21, 2020

In a Japanese environment, the component button that appears when using select mode displays only two characters.

To reproduce

  1. Set the language setting to Japanese.
  2. Use selection mode.
  3. Select any block.
  4. Then, the block name is displayed only for 2 characters.

Expected behavior
It should look like the following image.

wp54_expected

Screenshots
However, it now looks like the following image.

wp54_error

Solution
When "white-space: nowrap;" was applied to the component button (.edit-post-visual-editor .components-button), it became horizontal even in Japanese.

dev_tool

Verification environment

  • Mac OS
  • Google Chrome
  • WordPress 5.4-RC3-47477
@ddryo
Copy link
Contributor Author

ddryo commented Mar 21, 2020

The same problem occurs with the Replace button of the image block.

wp54_replace_img_btn

@waviaei
Copy link
Contributor

waviaei commented Mar 22, 2020

This is not Japanese environment issue, because I can recreate it with site's language setting set to:

Korean
スクリーンショット 2020-03-21 21 54 37

Chinese
スクリーンショット 2020-03-21 21 57 50

and English (US)
スクリーンショット 2020-03-22 17 20 34

All three are Mac OS and WordPress 5.4-RC3-47477. First two are Chrome, the last one is Firefox.

@aduth
Copy link
Member

aduth commented Mar 23, 2020

Thanks for reporting this issue. If you are able to, could you test to see if this is still an issue in newer versions of the Gutenberg plugin? Was it working correctly in versions of WordPress earlier than the 5.4 release candidates (WordPress 5.3.2)?

There is a significant redesign to this user interface in newer versions of the plugin (#19344) and this issue may have been affected as part of those changes.

I haven't yet debugged to confirm, but I'd wonder if this is in-part caused by a hard-coded width in the styling of these buttons.

@aduth aduth added [Feature] Blocks Overall functionality of blocks [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended labels Mar 23, 2020
@ddryo
Copy link
Contributor Author

ddryo commented Mar 24, 2020

In the latest version of Gutenberg it was displayed without problems!

スクリーンショット 2020-03-24 14 35 17

@ddryo
Copy link
Contributor Author

ddryo commented Mar 24, 2020

However, we will be using 5.4 for a while, so if you can fix the bug, please do.

@karmatosed karmatosed removed the [Status] Needs More Info Follow-up required in order to be actionable. label May 1, 2020
@skorasaurus
Copy link
Member

Hi,

I'm closing this since you have reported that this has been fixed in the latest version of Gutenberg. Please reopen if you are still experiencing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants