Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: the navigate region focus style is broken #21717

Closed
afercia opened this issue Apr 19, 2020 · 2 comments · Fixed by #45369
Closed

Regression: the navigate region focus style is broken #21717

afercia opened this issue Apr 19, 2020 · 2 comments · Fixed by #45369
Assignees
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Apr 19, 2020

Describe the bug
When jumping through the main ARIA landmarks in the editor (also known as "navigate-region" component) via the dedicated keyboard shortcuts, the focus style of the regions is broken, in slightly different ways on different browsers.

To reproduce

  • Test in different browsers, also on Windows.
  • Use the keyboard shortcuts to navigate through the landmarks.
  • on macOS:
    • Ctrl+backtick
    • Shift+Ctrl+backtick
  • on Windows (if I'm not mistaken):
    • Shift+Alt+N
    • Shift+Alt+P
  • see the focus style is broken on some of the regions

Expected behavior
The focus style to always be clearly visible.

Note
This style broke a few times during the project history. Maybe worth considering a different, more solid, testable, implementation.

Screenshots

With Gutenberg plugin activated.

Chrome Windows: content region focused: the style is visible only in the part of the UI close to the browser scrollbar:

Screenshot (95) content

Chrome Windows: sidebar region focused: the style is barely visible:

Screenshot (96) sidebar

Chrome macOS content region: no style visible:

chrome content

Chrome macOS sidebar region: style barely visible:

chrome sidebar

Chrome macOS publish region: no style visible:

chrome publish

Firefox macOS sidebar region: style breaks but in a different way:

firefox sidebar

Editor version (please complete the following information):

  • can reproduce with slightly different results on both:
    • default editor shipped with WP 5.4
    • plugin version 7.9.1
@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release labels Apr 19, 2020
@talldan
Copy link
Contributor

talldan commented Jun 17, 2021

I accidentally created a duplicate (#32758). When testing more recently it looks like the main editor area and publish panel link are the only two that don't have outlines.

For the main editor area, there are other elements overlapping the region. The CSS for the regions is here:
https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/higher-order/navigate-regions/style.scss

It might be possible to use a pseudo-element with a higher z-index to solve the overlapping issue.

@talldan talldan added CSS Styling Related to editor and front end styles, CSS-specific issues. General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jun 17, 2021
@afercia afercia self-assigned this Oct 18, 2022
@afercia
Copy link
Contributor Author

afercia commented Oct 19, 2022

WOrking on a PR right now. Just to note that we already tried a pseudo-element and we changed it in #8554. The problem with an absolutely positioned pseudo-element is that it scrolls when scrolling the post content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants