Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve adding media upload to a block #22273

Open
mkaz opened this issue May 11, 2020 · 1 comment
Open

Improve adding media upload to a block #22273

mkaz opened this issue May 11, 2020 · 1 comment
Labels
[Feature] Media Anything that impacts the experience of managing media Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.

Comments

@mkaz
Copy link
Member

mkaz commented May 11, 2020

Is your feature request related to a problem? Please describe.

When creating a new block that requires a media upload, there is a fair amount of complexity to get it right. You can see this in the core "Media & Text" block which ends up creating its own MediaContainer, to include the MediaPlaceholder and lots of additional functions to account for image vs video, resizing, blobUrl replacement and other aspects that go into an upload.

Additionally, even with the additional code in that block, an upload in-progress indicator is still not included. Digging through the Image block, shows the indicator is handled using a select data and mediaUpload function, though a fair amount of additional complexity that everyone who needs to create an upload will need to duplicate.

Describe the solution you'd like

Ideally, we create a single component for upload that is easy to use and requires a minimal of customization to get all the pieces to upload. This includes indicator, drag-drop, blobUrl replacement, etc...

@mkaz mkaz added [Feature] Media Anything that impacts the experience of managing media Needs Technical Feedback Needs testing from a developer perspective. labels May 11, 2020
@chrisvanpatten
Copy link
Member

I agree completely — the APIs here are pretty tricky to use. There's a lot of room for cleaning up this experience.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 8, 2021
@gwwar gwwar removed their assignment Oct 29, 2021
@skorasaurus skorasaurus removed the [Status] In Progress Tracking issues with work in progress label Jan 20, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants