Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add free-form crop #22582

Open
3 tasks
ajlende opened this issue May 23, 2020 · 3 comments
Open
3 tasks

Add free-form crop #22582

ajlende opened this issue May 23, 2020 · 3 comments
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@ajlende
Copy link
Contributor

ajlende commented May 23, 2020

#21024 introduced cropping with fixed aspect ratios. Sometimes, however, it would be nice to crop the image without being restricted by the available aspect ratios like in the original prototype.

rich-image prototype

Tasks

  • Add ability to free-form crop images from within the editor canvas (do we need to introduce a library for this?)
  • Improve visibility of cropping presets, so that after entering cropping mode, a user can quickly toggle between presets (or drag the free-form crop) without having to open a dropdown menu
  • Ensure that any added cropping tools can easily be added elsewhere, e.g. within a DataViews-powered Media Library as in: Phase 3: Collaboration > Media Library #55238
@ajlende ajlende added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media [Block] Image Affects the Image Block labels May 23, 2020
@mrfoxtalbot
Copy link

Thank you for reporting this @ajlende. I believe this is being discussed in #38990

I think we can close this issue in favor of the other one as it has a much lengthier discussion.

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2023
@mrfoxtalbot mrfoxtalbot added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label May 20, 2023
@ajlende
Copy link
Contributor Author

ajlende commented May 31, 2023

#38990 refers to the aspect-ratio CSS property that doesn't make edits to the image.

This issue refers to the actual image editor adding a drag crop interaction in conjunction to the zoom crop that exists.

@ajlende ajlende reopened this May 31, 2023
@ajlende ajlende removed the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label May 31, 2023
@andrewserong
Copy link
Contributor

andrewserong commented Jun 3, 2024

I know this is an old issue, but it'd be good to revive as there's still a need for good freeform cropping tools in the block editor. Another thing to look at is the visibility of the cropping presets. Currently, once you enter cropping mode, you need to know that this item in the toolbar allows you to select from cropping presets. I observed a user who was unable to find this dropdown after activating the cropping mode, so I'm wondering if while looking at free-form cropping, if we can also look at the visibility of the controls to select from presets. This is the dropdown I mean:

image

I've updated the issue description to reflect this note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
Status: 📋 Iteration/Tracking Issues
Development

No branches or pull requests

3 participants