Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Toolbar Disappears After Changing Alignment Settings #23214

Closed
zdenys opened this issue Jun 16, 2020 · 7 comments
Closed

Block Toolbar Disappears After Changing Alignment Settings #23214

zdenys opened this issue Jun 16, 2020 · 7 comments
Labels
[Block] Image Affects the Image Block Needs Testing Needs further testing to be confirmed.

Comments

@zdenys
Copy link

zdenys commented Jun 16, 2020

Describe the bug
Changing the alignment options for a Block hides the toolbar until I click outside of the block and then select it again.

To reproduce
Steps to reproduce the behavior:

  1. Add a Block that supports alignment options (such as Image, Cover, Group, Columns, Media & Text, Buttons etc.)
  2. Click on Change alignment icon in the block's toolbar
  3. Set it to a different value (Wide width, Full width etc.)
  4. See the Block toolbar disappear
  5. Click the block again (though it's still selected) and the toolbar doesn't appear until you click outside of the block and then click (select) the block one more time.

Expected behavior
See the Block toolbar re-appear again without the need to click away first or the Block not to lose focus at all (and hence the toolbar to stay visible all the time).

Screenshots

Screen Capture on 2020-06-16 at 19-17-08

Editor version:

@jeyip
Copy link
Contributor

jeyip commented Jun 16, 2020

I can reproduce this issue as well on atomic and simple sites with Gutenberg v8.3.0.

@talldan talldan added [Block] Image Affects the Image Block Needs Testing Needs further testing to be confirmed. labels Jun 17, 2020
@talldan
Copy link
Contributor

talldan commented Jun 17, 2020

I can reproduce the issue in 8.3.0, but not when checking out the code that's in the master branch, so it seems like it may have already been fixed.

I haven't been able to track down the pull request that fixed it though.

@oxyc
Copy link
Member

oxyc commented Jun 19, 2020

This seems to have fixed it 44f4054. If I revert it I can reproduce.

@zdenys
Copy link
Author

zdenys commented Jun 20, 2020

So it should be available in Gutenberg 8.4 as per #23089, right?

@oxyc
Copy link
Member

oxyc commented Jun 20, 2020

Yes

@oxyc
Copy link
Member

oxyc commented Jun 20, 2020

I'll close this issue as should be fixed but feel free to reopen next week after the Gutenberg plugin release if it doesn’t work as expected.

@oxyc oxyc closed this as completed Jun 20, 2020
@lsl
Copy link
Contributor

lsl commented Aug 11, 2020

Confirming this is now fixed - retested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

5 participants