Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: jwplayer embed #2505

Closed
carstenheisterkamp opened this issue Aug 23, 2017 · 8 comments
Closed

Feature Request: jwplayer embed #2505

carstenheisterkamp opened this issue Aug 23, 2017 · 8 comments

Comments

@carstenheisterkamp
Copy link

Jwplayer is a broadly used Video delivery platform which would be useful as an additional embed block. The default embed block can´t be used, since it provides Javascript as embed link or iFrame.

@youknowriad
Copy link
Contributor

This is probably better raised as a Core Trac ticket.
AFAIK, adding an embed provider requires the provider to implement the OEmbed protocol and it should match these guidelines https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers

@aduth
Copy link
Member

aduth commented Aug 23, 2017

This feels like plugin territory to me.

@ellatrix
Copy link
Member

@carstenheisterkamp Doesn't the Custom HTML block work for this? Maybe we need to make it a bit clearer that you can use it for embed codes too.

@carstenheisterkamp
Copy link
Author

@iseulde yes, technically this works with both the js and the iframe embed code. But you won´t have a preview of the video in the Gutenberg editor and it doesn´t have the nice one click add usability.

@ellatrix
Copy link
Member

Does the preview button not work? Similar to the the embed block, you have to paste the code, then click preview? Maybe we should persist that though.

@carstenheisterkamp
Copy link
Author

Just double checked it and honestly I totally overlooked the preview button... For iframe it works very well. The js code doesn´t sho a preview. The JS looks like this
<script src="//content.jwplatform.com/players/foUW87lp-e0pTZRtU.js"></script>
Don´t know it has some advantages over the iframe.

Is a formatting left/right/center/wide/full planned for the custom html block? This would help to define the width of the video. Currently it is full width only (or I am overlooking something again ;-) )

@ellatrix
Copy link
Member

ellatrix commented Aug 24, 2017

Yeah, if we detect scripts we probably need to iframe it. This would work:

<iframe srcdoc="&lt;script src=&quot;//content.jwplatform.com/players/foUW87lp-e0pTZRtU.js&quot;&gt;&lt;/script&gt;"></iframe>

(Would need to be resized as well.)

Or we need a separate block for admins only that handles all of this.

@karmatosed
Copy link
Member

I think this is dealt with the custom HTML block. If that is not the case, let me know and we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants