Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a site contains an empty reusable block, the editor crashes when opening the block inserter #26485

Closed
noahtallen opened this issue Oct 27, 2020 · 0 comments · Fixed by #26484
Closed

If a site contains an empty reusable block, the editor crashes when opening the block inserter #26485

noahtallen opened this issue Oct 27, 2020 · 0 comments · Fixed by #26484
Assignees
@noahtallen
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@noahtallen
Copy link
Member

Describe the bug
When the site has a reusable block which is empty (post content is an empty string), then opening the inserter for any post will cause a WSOD.

I have a fix here: #26484

To reproduce

  1. Create a reusable block
  2. Go to the reusable block post editor via manage reusable blocks
  3. Delete all blocks from the reusable block. It should be completely empty.
  4. Go to any post on your site in Gutenberg.
  5. Click the inserter button.
  6. The editor crashes to a WSOD

Expected behavior
The inserter should open. No crash!

Editor version (please complete the following information):

  • Current gutenberg trunk
@noahtallen noahtallen added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Oct 27, 2020
@noahtallen noahtallen self-assigned this Oct 27, 2020
@noahtallen noahtallen mentioned this issue Oct 27, 2020
Merged
@ockham ockham mentioned this issue Oct 28, 2020
Closed
@fullofcaffeine fullofcaffeine mentioned this issue Nov 12, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahtallen noahtallen

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix block inserter WSOD when an empty reusable block exists WordPress/gutenberg
1 participant
@noahtallen