Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field-level resolution in core data #26629

Open
adamziel opened this issue Nov 2, 2020 · 2 comments
Open

Field-level resolution in core data #26629

adamziel opened this issue Nov 2, 2020 · 2 comments
Labels
[Package] Core data /packages/core-data [Type] Enhancement A suggestion for improvement.

Comments

@adamziel
Copy link
Contributor

adamziel commented Nov 2, 2020

Core data should consider entities resolved during getEntityRecords() as also resolved for the purposes of the individual getEntityRecord() calls.

The problematic part is _fields part of the query. Calling getEntityRecords() without specifying _fields requests a "full" list of entities. If one passes _fields as a part of the query, the API will return only a subset of fields.

After merging #26575, getEntityRecord() will only be resolved by getEntityRecords() if _fields are missing from the query. This a good start, but it would still be possible to resolve specific entities as long as the same or a smaller subset of fields is requested. Otherwise an API round-trip would be required to fetch the missing fields.

One way to implement that would be having a more granular resolution mechanism. Something like "resolution per entity field" instead of "resolution per selector".

Related discussions:

@adamziel adamziel added the [Package] Core data /packages/core-data label Nov 2, 2020
@adamziel adamziel changed the title Field-level entity resolution Field-level resolution Nov 2, 2020
@adamziel adamziel changed the title Field-level resolution Field-level resolution in core data Nov 2, 2020
@jordesign
Copy link
Contributor

Hey @adamziel - I'm just looping back through some older issues. Wanted to see if this one has been resolved in the interim?

@Mamaduka
Copy link
Member

Hey, @jordesign. This logic hasn't been implemented yet.

@Mamaduka Mamaduka added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Core data /packages/core-data [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants
@adamziel @Mamaduka @jordesign and others