Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer block does not accept typed in height values in the Spacer settings input field #26693

Closed
korynorthrop opened this issue Nov 4, 2020 · 2 comments
Labels
[Block] Spacer Affects the Spacer Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@korynorthrop
Copy link

Describe the bug
The input field in the Spacer settings panel does not properly set values that are typed in.

To reproduce
Steps to reproduce the behavior:

  1. Add a Spacer block to a post
  2. Click on the block to access the Spacer settings panel
  3. Click on the height input field and select the current value
  4. Type in a new value (e.g. 65)
  5. Notice that the typed in value is not set, instead the input shows a different value

Expected behavior
I expect the input field to set the typed in height value and then see the new value reflected in the Spacer block itself in the Gutenberg editor.

Screenshots
Here is a screenshot of the issue, the values I typed into the height input field were "65" and then "30" which resulted in "205" and "200" respectively.

spacer height

Editor version (please complete the following information):

  • WordPress version: 5.3.3
  • Using the default block editor that comes with this version of WordPress

Desktop (please complete the following information):

  • OS: OSX
  • Browser: Firefox
  • Version 82.0.2
@talldan
Copy link
Contributor

talldan commented Nov 5, 2020

Thanks for reporting @korynorthrop.

This issue has been fixed in recent versions of the Gutenberg plugin. A fix will be in the upcoming WordPress 5.6 release.

This is the changed that fixed it if you're interested - #25528. In that change the minimum height of the spacer was also reduced to 1px.

@talldan talldan closed this as completed Nov 5, 2020
@talldan talldan added [Block] Spacer Affects the Spacer Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Nov 5, 2020
@korynorthrop
Copy link
Author

@talldan thanks for the follow-up, sorry I didn't see the other issues that addressed this bug. Glad to see that it'll be sorted out in the upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Spacer Affects the Spacer Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants