Full-height button in Cover: move to dropdown and make Fullscreen

[jasmussen]

The Cover block has a cool new "full height" button, which sets its height to 100vh in the sidebar controls, and acts as a convenenient toggle:

Upon testing this, it seems like you'd nearly always want to combine the 100vh height with full-wide. And in doing so, it could be grouped along with the other alignments/positions. Like so:

That would also allow us, separately from this effort, to expand the feature to more blocks than just Cover.

[ntsekouras]

And in doing so, it could be grouped along with the other alignments/positions. Like so:

No strong opinion here but I think we shouldn't combine fullscreen with alignment options as they are different things, even if fullscreen and wide could be usually combined.

[retrofox]

And in doing so, it could be grouped along with the other alignments/positions. Like so:

No strong opinion here but I think we shouldn't combine fullscreen with alignment options as they are different things, even if fullscreen and wide could be usually combined.

Yeah... I have a similar feeling but don't have a strong opinion either. In some way, we're going to lose the ability to combine full height with all other alignments.

[jasmussen]

Excellent question to bring up and work out here in the thread.

The point of the issue is that you'll almost never want to have just full-height (and if you do, you can in the sidebar with 100vh). You'll almost always want full height and full width. And you can't do 100vw and vh inside post content. So the only solution to getting actual fullscreen, is to combine full-wide with 100vh.

To me, that means the button could sit right below full-wide and toggle both.

[paaljoachim]

Let's see here... thinking out loud.
We have a "Change Alignment" drop down.

Align left - pushes to the left.
Align center - pushes to center.
Align right - pushes to the right.
Wide width - creates an extra wide Cover block.
Full width - pushes to the way to the left and right.

Similar to the Full width alignment we have a Full height toggle. As we have the Full width inside the alignment drop down it seems fitting to also have a Full height alignment in the same drop down. One could then do a multi select and select to have Full width and a Full height. Like so. (I have made some adjustments to the current icons. To signal full width and full height.)

Btw
Another alignment I really would like to add is a default width that is by default always selected. So a user can see the default width is selected and then choose something else if they want to. #20941
I do think we discussed this in another issue a while ago. Arguments were brought up why my suggestion was not a great idea. That is though a sidetrack to moving the Full-height button to the alignment drop down issue we are discussing here.

[jasmussen]

Revisiting this one in light of many of the alignment refactors that have happened since this conversation, I actually tend to think we should keep the button as-is, at least for now, and then revisit/reopen if a need arises.