Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich text to the site title block #27830

Closed
carolinan opened this issue Dec 19, 2020 · 4 comments · Fixed by #31734
Closed

Add rich text to the site title block #27830

carolinan opened this issue Dec 19, 2020 · 4 comments · Fixed by #31734
Assignees
Labels
[Block] Site Title Affects the Site Title Block [Status] In Progress Tracking issues with work in progress

Comments

@carolinan
Copy link
Contributor

carolinan commented Dec 19, 2020

Is your feature request related to a problem? Please describe.

The site title block is in many ways a heading block, but it does not have the same controls.

I would like to be able to edit it as HTML, to split the text into two lines, and I would like to be able to use the inline color tool to
have two different text colors.

The buttons are not even in the same position and the font weight for the heading level is different. I think it would be good to make them consistent:

site-title-comparison

@carolinan carolinan added the [Block] Site Title Affects the Site Title Block label Dec 19, 2020
@mtias
Copy link
Member

mtias commented Dec 21, 2020

This came up a few times before (used to be rich text) and the main issue is inline html is not allowed to be saved on the title, so block level transforms are the only ones available.

@carolinan
Copy link
Contributor Author

So the solution would be to allow saving of HTML but remove it before output inside a title attribute?

@mtias
Copy link
Member

mtias commented Jan 18, 2021

Since the site title attribute can be used in multiple ways in WordPress and allowing encoded html would be a breaking change we'd need to figure out a different way to save formatting while leaving the option in plain text. This could get tricky, since if we separate formatting from the raw data we could run into sync issues. At that point probably the easiest is to keep the data in html and sync on edit to the site option if you want to user inline formatting.

@glendaviesnz
Copy link
Contributor

@carolinan - text format options have been added in #31734, it seems that currently this is the only option for adding additional formatting options to this block given the inability to support rich text, but will let you decide if you want this ticket to remain open for further exploration of rich text support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Title Affects the Site Title Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants