Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss the need for a CSS framework #28144

Open
chvillanuevap opened this issue Jan 12, 2021 · 2 comments
Open

Discuss the need for a CSS framework #28144

chvillanuevap opened this issue Jan 12, 2021 · 2 comments
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Discussion For issues that are high-level and not yet ready to implement.

Comments

@chvillanuevap
Copy link

I am in the process of migrating the theme for my wife's business from the Genesis framework to only using blocks. My wife's website uses WooCommerce + Sensei to sell eBooks and video courses. But really, I just wanted an excuse to play with the new FSE tool. As I'm moving blocks and trying to create a copy of the Genesis theme, I found myself using a lot of "helper" classes to customize the display (is-flex, is-inline-block, has-uppercase-text-transform, is-open-sans-font, etc.). I included all of these helper classes in my stylesheet.

I wonder if WordPress and/or Gutenberg should provide a common CSS framework for customizing these blocks. There is some precedent, as the class "is-vertically-aligned-center" exists for flex. I feel that if the goal of the FSE is to avoid having to code, then the best way to customize the display of the blocks is to use the "Additional CSS class(es)" field.

I was just wondering if you had considered this, and what the cons to this approach would be.

@chvillanuevap
Copy link
Author

I guess what I'm trying to avoid is to have each separate plugin have their own helper classes. For example, have .no-border-radius vs. .is-radiusless vs. .has-no-border-radius all do the same thing: border-radius: 0.

@johnstonphilip johnstonphilip added the CSS Styling Related to editor and front end styles, CSS-specific issues. label Jan 13, 2021
@skorasaurus skorasaurus added the [Type] Discussion For issues that are high-level and not yet ready to implement. label Feb 6, 2021
@Tartamata
Copy link

Im also interested in discussion, any news @chvillanuevap ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Discussion For issues that are high-level and not yet ready to implement.
Projects
None yet
Development

No branches or pull requests

4 participants