Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Changelog generation script git-based #28430

Open
ockham opened this issue Jan 22, 2021 · 0 comments
Open

Make Changelog generation script git-based #28430

ockham opened this issue Jan 22, 2021 · 0 comments
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Enhancement A suggestion for improvement.

Comments

@ockham
Copy link
Contributor

ockham commented Jan 22, 2021

Spun off from #28424:

We should maybe reconsider our source of truth for Changelog generation: Maybe we shouldn't query the list of issues/PRs for the milestone from the GitHub API. Instead, we have more reliable information right at our fingertips: git itself. We might just want to call git log with some arguments to get that exact kind of information (in a more reliable way than from GH's milestone, which just manually replicates that information). If we still want/need PR numbers etc, we can probably query those from the GH API, based on the Changelog obtained from git.

@ockham ockham added [Type] Enhancement A suggestion for improvement. [Type] Build Tooling Issues or PRs related to build tooling labels Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant