Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Screen: Update Navigation block inspector #28864

Closed
shaunandrews opened this issue Feb 8, 2021 · 3 comments · Fixed by #29458
Closed

Navigation Screen: Update Navigation block inspector #28864

shaunandrews opened this issue Feb 8, 2021 · 3 comments · Fixed by #29458
Assignees
Labels
[Feature] Inspector Controls The interface showing block settings and the controls available for each block [Status] In Progress Tracking issues with work in progress

Comments

@shaunandrews
Copy link
Contributor

On the Navigation Screen, the Navigation block's sidebar inspector includes controls for auto-adding new pages and deleting the menu. Here's how it looks now:

image

I think we should improve the display of the auto-add option and the delete button, along with adding theme locations. Here's an updated design:

image

The new "Theme locations" accordion allows you to choose where the current menu will appear. Clicking the "Manage locations" button opens a modal that allows you to choose a menu for all theme locations at the same time. Each location allows you to either choose an existing menu, edit an existing menu, create a new menu, or select no menu. Here's a look at how it could work:

Manage Locations

@shaunandrews shaunandrews added [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Feature] Navigation Screen labels Feb 8, 2021
@shaunandrews shaunandrews added this to Inbox in Navigation editor via automation Feb 8, 2021
@talldan talldan moved this from Inbox to Needs dev in Navigation editor Feb 9, 2021
@talldan
Copy link
Contributor

talldan commented Feb 9, 2021

This is a really nice improvement. 👏

If there's already a menu assigned to one of the locations, do you think we need to inform the user that using the checkbox in the sidebar would overwrite the previous assignment?

@shaunandrews
Copy link
Contributor Author

If there's already a menu assigned to one of the locations, do you think we need to inform the user that using the checkbox in the sidebar would overwrite the previous assignment?

Perhaps we can take a cue from the existing Menu's screen, and add a byline to areas that already have an assigned menu:

image

@shaunandrews
Copy link
Contributor Author

It seems (for the time being, at least) we'll also add the menu name as an input to the sidebar. Here's how that could look:

image

The block toolbar could still display the menu's name, and when clicked could highlight the input in the sidebar:

Click Menu Name to Focus Input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inspector Controls The interface showing block settings and the controls available for each block [Status] In Progress Tracking issues with work in progress
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants