Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block styles not loading in navigation editor when using an FSE theme (e.g. TT1 Blocks) #28874

Closed
talldan opened this issue Feb 9, 2021 · 3 comments · Fixed by #30076
Closed
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Feb 9, 2021

Description

Block styles don't seem to be loading in the navigation editor when TT1 blocks is used as the theme.

Several issues can be seen, like empty submenus taking up space.

Step-by-step reproduction instructions

  1. Use the theme TT1-Blocks
  2. Add multiple links
  3. Observe the space between links

Expected behaviour

There is no empty space

Actual behaviour

There is empty space

Screenshot

Screenshot 2021-02-09 at 6 40 50 pm

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Navigation Screen labels Feb 9, 2021
@talldan talldan added this to Inbox in Navigation editor via automation Feb 9, 2021
@talldan talldan moved this from Inbox to Needs dev in Navigation editor Feb 9, 2021
@tellthemachines
Copy link
Contributor

Could this be related to #27995?

@talldan
Copy link
Contributor Author

talldan commented Feb 10, 2021

It seems like none of the block styles are loading in the navigation editor, which also explains why the page list block looks different.

@talldan
Copy link
Contributor Author

talldan commented Feb 10, 2021

Just discovered by complete accident that this bug only happens when TT1-Blocks is the active theme. With regular Twenty Twenty One it works as expected.

@talldan talldan changed the title Empty Navigation block submenus showing as empty space in the Navigation Editor Block styles not loading in navigation editor when using an FSE theme (e.g. TT1 Blocks) Feb 10, 2021
@talldan talldan moved this from Needs dev to Issues in progress in Navigation editor Mar 22, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 22, 2021
Navigation editor automation moved this from Issues in progress to Done Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants