Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Android) Splitting and merging a Paragraph/Heading block doesn't work correctly #29478

Closed
geriux opened this issue Mar 2, 2021 · 4 comments · Fixed by #29502 or #29683
Closed

(Android) Splitting and merging a Paragraph/Heading block doesn't work correctly #29478

geriux opened this issue Mar 2, 2021 · 4 comments · Fixed by #29502 or #29683
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects

Comments

@geriux
Copy link
Member

geriux commented Mar 2, 2021

Description

While running the writing flow tests on the Mobile editor release 1.48.0 an issue was found regarding splitting and merging content in a Paragraph/Heading block.

Step-by-step reproduction instructions

  1. Open the mobile editor
  2. Write (or paste) a paragraph with a few lines
  3. Set the caret by the half of the paragraph
  4. Press Enter (Intro) to split the block into two. (if using the simulator, use the device keyboard)
  5. Move the caret a few words.
  6. Delete all those words until the blocks merge.
  7. See that the original content of the first Paragraph block shows up causing the content to be duplicated.

Expected behaviour

The two blocks should merge without any content duplication.

Actual behaviour

After emerging the two blocks the original content of the first Paragraph block returns causing content duplication.

Screenshots or screen recording (optional)

Screenrecorder-2021-03-02-14-29-38-946.mp4

Device information

  • Device: Redmi Note 8T (Or Pixel simulator)
  • Operating system: Android 10
@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 2, 2021
@geriux
Copy link
Member Author

geriux commented Mar 2, 2021

This is a regression from #28505.

@geriux geriux changed the title (Android) Splitting and merging a Paragraph block doesn't work correctly (Android) Splitting and merging a Paragraph/Heading block doesn't work correctly Mar 2, 2021
@geriux geriux added the [Type] Bug An existing feature does not function as intended label Mar 2, 2021
@cameronvoell
Copy link
Member

cameronvoell commented Mar 3, 2021

@geriux I was taking a look at this and don't have a solution yet but I did find some simpler steps to reproduce:

  1. Paste text
  2. move cursor halfway and use emulator keyboard to press enter
  3. Switch to HTML mode
  4. Notice incorrect text
    *Note if you use those same steps with your computers physical keyboard controlling the emulator to press enter, the correct text will show in html mode.
    broken-text

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 3, 2021
@hypest hypest added this to Triage in Mobile Apps via automation Mar 4, 2021
@hypest hypest moved this from Triage to In progress in Mobile Apps Mar 4, 2021
Mobile Apps automation moved this from In progress to Done Mar 4, 2021
@geriux geriux reopened this Mar 5, 2021
Mobile Apps automation moved this from Done to In progress Mar 5, 2021
@geriux
Copy link
Member Author

geriux commented Mar 5, 2021

Reopening since the first approach to fix it didn't work.

@geriux geriux removed the [Status] In Progress Tracking issues with work in progress label Mar 5, 2021
@geriux geriux removed their assignment Mar 5, 2021
@geriux
Copy link
Member Author

geriux commented Mar 8, 2021

I just reverted the PR I made to try to fix it but ended up not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
Mobile Apps
  
Done
3 participants