Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Site Editing: Template label in top bar is not correctly centrally aligned #29673

Closed
jameskoster opened this issue Mar 9, 2021 · 5 comments · Fixed by #59134
Closed

Full Site Editing: Template label in top bar is not correctly centrally aligned #29673

jameskoster opened this issue Mar 9, 2021 · 5 comments · Fixed by #59134
Assignees
@jameskoster @mikachan
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Due to justify-content: space-between; being applied to .edit-site-header and the difference in width between .edit-site-header_start and .edit-site-header_end, .edit-site-header_center is not correctly centrally aligned:

Screenshot 2021-03-09 at 13 21 41
@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts [Feature] Full Site Editing labels Mar 9, 2021
@jameskoster jameskoster changed the title Full Site Editing: Template label in top bar is not correctly centrally align Full Site Editing: Template label in top bar is not correctly centrally aligned Mar 22, 2021
@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label May 23, 2022
@mikachan mikachan assigned mikachan and unassigned mikachan Nov 9, 2022
@bangank36
Copy link
Contributor

I'll take over this issue

@mikachan mikachan mentioned this issue Nov 9, 2022
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 9, 2022
@bangank36 bangank36 mentioned this issue Nov 9, 2022
Closed
@jameskoster jameskoster mentioned this issue Mar 30, 2023
Closed
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@jordesign
Copy link
Contributor

Closing this issue as the design of the top toolbar has changed now.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2023
@jameskoster
Copy link
Contributor Author

It's still not centrally aligned though 🙈

Screenshot 2023-09-08 at 10 22 09

(Red line in the screenshot above is center).

@jameskoster jameskoster reopened this Sep 8, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 14, 2023
@colorful-tones
Copy link
Member

I just wanted to post verification, and it still needs to be centered.

Screenshot 2023-11-20 at 12 07 36 PM

@Sirjazzfeetz
Copy link

Sirjazzfeetz commented Feb 15, 2024 •
edited

3rd year anniversary coming up...

Image

@jameskoster jameskoster mentioned this issue Feb 15, 2024
Closed
@richtabor richtabor mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskoster jameskoster

@mikachan mikachan

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Polish
Status: Done
Milestone
No milestone
8 participants
@colorful-tones @mtias @jameskoster @mikachan @jordesign @bangank36 @annezazu @Sirjazzfeetz