Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Content Block #30574

Closed
jameskoster opened this issue Apr 7, 2021 · 7 comments · Fixed by #35183
Closed

Comment Content Block #30574

jameskoster opened this issue Apr 7, 2021 · 7 comments · Fixed by #35183
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

Here is an initial take on the design for the Comment Content block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).

comment-content

Design feedback is politely requested for all aspects:

  • Icon
  • Placeholder when there is no context present
  • Toolbar actions
  • Inspector settings
  • Name
  • Description

Figma link here.

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 7, 2021
@jameskoster jameskoster added [Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Apr 7, 2021
@paaljoachim
Copy link
Contributor

Hey James

Here I am wondering if we should have color controls (text and background). Perhaps even typography controls.
The icon looks good.

"The content of the comment." Add the punctuation.

An additional control might be to add border control. As well as some padding.

@jameskoster
Copy link
Contributor Author

Excellent feedback. I agree on all points :)

If possible, it would be cool to use the design tools from #27331 for the color, padding, and typography controls. But I don't know if they are ready yet.

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 21, 2021

At the moment we can focus on what is ready. Taking one step at a time.
When additional controls are ready then these new controls can be added.

Of course the mockup can show controls that are not ready to be implemented, but when a developer picks up this issue and creates the block then he/she will see which controls are ready to be added.

@SantosGuillamot
Copy link
Contributor

Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one:

Description

Displays the content of the comment.

Potential Settings

  • Typography: It should be the same as the Paragraph block.
  • Color Settings: It should be the same as the Paragraph block.
  • Layout Settings: It should be the same as the Post Content block. It can inherit the default layout or change the width and content.

References

Of course, any feedback is welcome 🙂

@SantosGuillamot SantosGuillamot added this to To do in Comments Loop block via automation Sep 21, 2021
@SantosGuillamot SantosGuillamot added New Block Suggestion for a new block [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop and removed Needs Design Feedback Needs general design feedback. labels Sep 21, 2021
@DAreRodz
Copy link
Contributor

Hi all, 👋 I would like to create a draft PR and start working on this. @SantosGuillamot could you assign this issue to me? 😊

@DAreRodz
Copy link
Contributor

Hey, 👋 I had a few questions when I started working on this.

Looking at the design @jameskoster shared, it looks like the block shows a generic message when no context is provided. I understand that this happens when the comment ID is not specified in the parent block, am I right? What should the block show when the comment ID is not correct? Is it OK showing the same message?

Regarding the icon, I guess I have to create a new one inside @wordpress/icons using the design, right?

My last question is related to the settings this block will have. I've added those that @SantosGuillamot proposed, although in the design also appear some buttons to make the text bold o italic. I'm not sure, but these settings don't seem quite possible to be added as that would modify the comment content, if I'm not mistaken.

I'll keep working on adding tests and comments in the meantime. Thanks in advance. 🙂

@jameskoster
Copy link
Contributor Author

Yay! I'll leave my feedback on the PR 👍

@SantosGuillamot SantosGuillamot moved this from In progress to In review in Comments Loop block Oct 15, 2021
Comments Loop block automation moved this from In review to Done Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants