Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-tap and hold accessibility gesture is not supported by range cell slider #31049

Open
dcalhoun opened this issue Apr 21, 2021 · 2 comments
Labels
[Block] Columns Affects the Columns Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Package] Block library /packages/block-library [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later
Projects

Comments

@dcalhoun
Copy link
Member

dcalhoun commented Apr 21, 2021

Description

When attempting to change the current value of a slider input for Columns, the double-tap and hold accessibility action is not supported. One can still modify the slider value by selecting the input and then swiping up/down, but it would be good to support the double-tap and hold gesture as well. This issue was identified in #30636 (review).

Step-by-step reproduction instructions

  1. Enable VoiceOver/TalkBack.
  2. Launch the block editor on WPiOS or WPAndroid.
  3. Add a Column block.
  4. Open the block Settings bottom sheet (i.e. tap gear icon).
  5. Select a column layout.
  6. Select one of the column inputs.
  7. Double-tap and hold then drag the slider.

Expected behaviour

The slider value decrements/increments when sliding left/right.

Actual behaviour

The slider value does not change when sliding left/right.

Screenshots or screen recording (optional)

In the video, there is an attempt to modify Column 1 with the steps above. The successful modification of the Column 2 value was done using the supported swipe up/down gestures.

RPReplay_Final1619018412.MP4

WordPress information

  • WordPress version: 5.7
  • Gutenberg version: v10.4.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: iPhone SE, Samsung Galaxy S20
  • Operating system: iOS 14.4.2, Android 11
  • WordPress app version: 17.1
@dcalhoun dcalhoun added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Package] Block library /packages/block-library [Block] Columns Affects the Columns Block labels Apr 21, 2021
@mchowning mchowning added this to Triage in Mobile Apps via automation Apr 22, 2021
@mchowning mchowning moved this from Triage to To do in Mobile Apps Apr 22, 2021
@mchowning mchowning added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Apr 22, 2021
@mchowning
Copy link
Contributor

Thanks for reporting this issue @dcalhoun ! 🙇

I marked this as "low" priority since it seems like there is a pretty straightforward workaround for this by swiping up and down, but if you think this may be a blocking issue for some of our users, let's make this a high priority issue. wdyt?

@dcalhoun
Copy link
Member Author

dcalhoun commented Apr 22, 2021

I marked this as "low" priority since it seems like there is a pretty straightforward workaround for this by swiping up and down, but if you think this may be a blocking issue for some of our users, let's make this a high priority issue. wdyt?

@mchowning I think it is fine to mark it as "low" for now. I'm not sure which gesture is most common for controlling sliders, but the accessibility announcement for the slider directs users to use the swipe up/down gesture that does work. Hopefully that will prevent users from being blocked until we support the double-tap and hold gesture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Package] Block library /packages/block-library [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later
Projects
Mobile Apps
  
To do
Development

No branches or pull requests

2 participants