Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: BottomSheetTextControl Component: Get Text Area to Automatically Expand/Shrink with Text Entry #31281

Closed
SiobhyB opened this issue Apr 28, 2021 · 0 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Package] Components /packages/components [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Apr 28, 2021

Description

The BottomSheetTextControl component currently has a text area with a set height:

112876262-348ff380-90bd-11eb-8637-f0878ed94dea

If a user enters a large amount of text into the text area, they need to scroll within that area to view all of it, the area doesn't automatically expand/shrink to make all text visible. Around three lines of text are visible on the screen at a time, with any more being visible upon scroll.

The current behaviour was agreed upon as part of this feedback thread and currently makes sense given that the component is currently only used for the image block's alt text settings (which doesn't generally entail that many lines of text).

However, it could be a nice enhancement for the component to automatically expand/shrink with text, especially if it goes onto be used in other places in the editor where it's expected that multiple lines of text will be used.

Step-by-step reproduction instructions

  1. Open Image Block settings.
  2. Tap Alt Text and confirm that a new sub sheet opens with an area to enter text.
  3. Enter multiple lines of text into the area and confirm that it doesn't expand, instead you're able to scroll to view any text not visible within it.

Expected behaviour

The following feedback was provided by a colleague who tested the above steps:

I feel like the text area should expand as I type rather than creating a small scrollable area. Was most noticeable on iPad where there was room to spare, it seemed unnecessary to scroll in the small content area.

Actual behaviour

The area doesn't currently expand, with any text overflowing the view only visible on scroll. It could be a nice enhancement to change this behaviour in the future.

@SiobhyB SiobhyB added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Package] Components /packages/components labels Apr 28, 2021
@mchowning mchowning added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Apr 29, 2021
@mchowning mchowning added this to Triage in Mobile Apps via automation Apr 29, 2021
@mchowning mchowning moved this from Triage to To do in Mobile Apps Apr 29, 2021
@SiobhyB SiobhyB closed this as completed Feb 27, 2024
Mobile Apps automation moved this from To do to Done Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Package] Components /packages/components [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
Mobile Apps
  
Done
Development

No branches or pull requests

2 participants