Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine border style dropdown design #31333

Closed
Tracked by #33447
jameskoster opened this issue Apr 29, 2021 · 5 comments
Closed
Tracked by #33447

Refine border style dropdown design #31333

jameskoster opened this issue Apr 29, 2021 · 5 comments
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback.

Comments

@jameskoster
Copy link
Contributor

The border style selector added in #31321 could use a little design refinement:

Screenshot 2021-04-29 at 11 47 18

This unique treatment of the dropdown component adds unnecessary weight to the UI, and the combination of label + preview feel like overkill. It might be simpler to do one or the other:

  1. A standard select with no preview
  2. A segmented control with icons (like the width control shared in Sidebar Controls & Component System #27331), example below

Screenshot 2021-04-29 at 13 03 14

@jameskoster jameskoster added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. labels Apr 29, 2021
@aaronrobertshaw
Copy link
Contributor

I've started putting together a PR to refine the border block support controls. Can you provide the icons for the segmented control? It will also need a "none" option so the user can explicitly remove a border when the theme sets one.

@aaronrobertshaw
Copy link
Contributor

We might get away with relying on setting the border width to 0 to hide a theme provided border. That wouldn't be obvious to end users though.

@jameskoster
Copy link
Contributor Author

We might get away with relying on setting the border width to 0 to hide a theme provided border. That wouldn't be obvious to end users though.

That was my original thinking. If we begin with only one variable to control the visibility of the border, I think that will lead to fewer confusing scenarios overall.

Here's the svg code for the icons:

Solid

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none">
  <defs/>
  <path d="M5 11.25h14v1.5H5z"/>
</svg>

Dashed

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none">
  <defs/>
  <path fill-rule="evenodd" d="M5 11.25h3v1.5H5v-1.5zm5.5 0h3v1.5h-3v-1.5zm8.5 0h-3v1.5h3v-1.5z" clip-rule="evenodd"/>
</svg>

Dotted

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none">
  <defs/>
  <path fill-rule="evenodd" d="M5.25 11.25h1.5v1.5h-1.5v-1.5zm3 0h1.5v1.5h-1.5v-1.5zm4.5 0h-1.5v1.5h1.5v-1.5zm1.5 0h1.5v1.5h-1.5v-1.5zm4.5 0h-1.5v1.5h1.5v-1.5z" clip-rule="evenodd"/>
</svg>

@aaronrobertshaw
Copy link
Contributor

Work toward refining the border block support UI is currently in progress in #31585.

The designs in #31337 required some updates to the underlying block supports mechanism that are still pending review. Any help getting those reviewed will help move this forward.

@aaronrobertshaw
Copy link
Contributor

Closing this as the border panel has been updated now #31585 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback.
Projects
Status: Done
Development

No branches or pull requests

2 participants