[Discussion]: gutenberg_block_has_support validations

[ntsekouras]

While adding some unit tests for gutenberg_block_has_support in core here: WordPress/wordpress-develop#1280, I found it pretty weird that we just check if the value of a supports flag can return true even if as an empty array here: https://github.com/WordPress/gutenberg/blob/trunk/lib/blocks.php#L413

Should this return true as it does now? Should we add some more basic validations?

Example test that passes with an empty array:

public function test_block_has_support_empty_array() {
	$this->registry->register(
		'core/example',
		array(
			'supports' => array(
				'align' => array(),
			),
		)
	);
	$block_type = $this->registry->get_registered( 'core/example' );
	$align_support = block_has_support( $block_type, array( 'align' ) );
	$this->assertSame( $align_support, true );
}