Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor top bar and top toolbar separated by notices, notices overlapped when scrolling #32257

Closed
talldan opened this issue May 27, 2021 · 2 comments · Fixed by #32238
Closed
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented May 27, 2021

Description

Recently the BlockTools component was introduced and the TopToolbar was moved below notices, which has the benefit that users can shift-tab directly from a block to the top toolbar. It had a couple of unwanted side-effects:

  • Notices look a little unusual when they separate the editor topbar and the top toolbar.
  • When scrolling, the top toolbar moves and overlaps the notices.

Step-by-step reproduction instructions

  1. Enable top toolbar mode
  2. Create some notices using the following snippet in the browser console - wp.data.dispatch( 'core/notices' ).createInfoNotice( 'hello' );
  3. Add enough blocks that the editor has a scroll bar
  4. Scroll up and down

Expected behaviour

The visual aspect of the notices and toolbars are improved and the top toolbar doesn't overlap the notices.

Screenshots or screen recording (optional)

scrolly-toolbar

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels May 27, 2021
@talldan talldan added this to 📥 To do in WordPress 5.8 Must Haves via automation May 27, 2021
@jasmussen jasmussen moved this from 📥 To do to 🏗️ In progress in WordPress 5.8 Must Haves May 27, 2021
@youknowriad
Copy link
Contributor

@jasmussen Is this something we should close now?

@jasmussen
Copy link
Contributor

Yes, I had thought that my PR merging would do that.

WordPress 5.8 Must Haves automation moved this from 🏗️ In progress to ✅ Done Jun 2, 2021
@talldan talldan linked a pull request Jun 8, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants