Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio block - Show notice message for non audio URLs #32456

Open
geriux opened this issue Jun 4, 2021 · 2 comments
Open

Audio block - Show notice message for non audio URLs #32456

geriux opened this issue Jun 4, 2021 · 2 comments
Labels
[Block] Audio Affects the Audio Block [Type] Enhancement A suggestion for improvement.

Comments

@geriux
Copy link
Member

geriux commented Jun 4, 2021

Description

When adding a non-audio URL in an Audio block, it'd be nice to show some sort of error/warning message to let the user know that it's not supported and it won't play.

Step-by-step reproduction instructions

  1. Add an Audio block
  2. Insert a non-audio URL

Expected behaviour

  1. Add an Audio block
  2. Insert a non-audio URL
  3. Expect to see some sort of warning/error when loading a non-audio URL.

Actual behaviour

  1. Add an Audio block
  2. Insert a non-audio URL
  3. See the block added but it can't be played since it's not a valid format without any kind of warning.

Screenshots or screen recording (optional)

Web

Mobile

WordPress information

  • Gutenberg version: Current version 10.8.0

Device information

  • Device: Web / Mobile
  • Operating system: Web / Mobile native
@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 4, 2021
@hypest
Copy link
Contributor

hypest commented Jun 7, 2021

👋 @geriux , thanks for reporting! My understanding is that the same issue exists for the web version too, no warning is displayed. Since we already have relevant a native mobile ticket over at the gutenberg-mobile repo, what do you think about removing the Mobile App label on this one to make it into a platform independent ticket? If so, can you add a note in the description that this refers both to the web and mobile? Thanks!

@geriux
Copy link
Member Author

geriux commented Jun 14, 2021

Since we already have relevant a native mobile ticket over at the gutenberg-mobile repo, what do you think about removing the Mobile App label on this one to make it into a platform independent ticket?

Sounds good! Totally missed that other ticket, I'll update this issue to make it non-mobile specific. 👍

@geriux geriux added [Block] Audio Affects the Audio Block and removed Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jun 14, 2021
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Audio Affects the Audio Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants