Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Excerpt Block: Add the ability to style "Read more" independently #33288

Closed
kjellr opened this issue Jul 8, 2021 · 4 comments · Fixed by #37649
Closed

Post Excerpt Block: Add the ability to style "Read more" independently #33288

kjellr opened this issue Jul 8, 2021 · 4 comments · Fixed by #37649
Assignees
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 8, 2021

Today, the read more link generally inherits the style settings of the entire excerpt. Since it's a link, you can adjust the color by using the experimental link color feature, and since it's inline text, you can use options like Bold, Italic, etc.

The alignment cannot be adjusted independently, and neither can the font size.

I expected the read more text to be a standard, separate child block that would have its own set of controls. Adopting this implementation would allow for a wider range of design options. (Maybe even the ability to change the link into a button?)

GIF of current state:

read-more

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Block] Post Excerpt Affects the Post Excerpt Block labels Jul 8, 2021
@scruffian
Copy link
Contributor

In addition to this, it would be useful to be able to add an arrow (like →) to the link...

@getdave
Copy link
Contributor

getdave commented Oct 6, 2021

Related - should we not have a separate block for this?

@annezazu
Copy link
Contributor

This came up as part of the tenth call for testing for the FSE Outreach program and the solution explored here I believe will address the root issue of the current experience being unclear that you can customize this part of the Post Excerpt block:

Post Excerpt – there’s a section to ‘add “read more” link text‘ (which I’m not sure what it means?) that if you click on, it doesn’t show the blinking “|” which signifies that you can add text to it (although it does work and you can add text). If you click directly right after it, it’ll then show the blinking “|” and that acts as more of a sign that you can modify and add text. It might be a bit confusing for some users from a visual cue standpoint

Happy to open a separate issue but, to me, this helps provide more context for why it's important to have the ability to style this aspect separately.

@critterverse
Copy link
Contributor

Would love to have this functionality! Here's a look at how this might work with a new Read More block that acts as a child to the Post Excerpt block.

Post Excerpt block — before:

post-excerpt-before

Post Excerpt block — after, with new Read More child block:

read-more

Here's how it would look from the List view. The parent/child relationship could work similarly to the Buttons/Button block where the child never exists independently of the parent:

read-more-list-view

Notes:

  • Currently, there's an option to include the "Read more" link on the same line as the excerpt text or on a new line. This option doesn't seem to make as much sense with a separate block
  • Instead, there could be an option for the Read More block to have a text link or button-style link. These options could be available in the block settings Style panel
  • When a button Style is selected, two additional panels could be added to the sidebar ("Border" and "Width settings")
  • Otherwise, the toolbar and block settings could be the same for the Read More block as the parent Post Excerpt block
  • There is an existing “More” block (for use within Content only) so there may be some confusion between this and the Read More block. The existing More block feels like legacy functionality that will probably soon be handled by the Post Excerpt block settings — I wonder if this block could be hidden entirely for block themes?
  • TBD: icon for Read More block

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants