Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all pages option doesn't work in Navigation screen #33999

Closed
3 tasks done
tellthemachines opened this issue Aug 11, 2021 · 1 comment · Fixed by #34568
Closed
3 tasks done

Add all pages option doesn't work in Navigation screen #33999

tellthemachines opened this issue Aug 11, 2021 · 1 comment · Fixed by #34568
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@tellthemachines
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Have you tried deactivating all plugins except Gutenberg?

  • I have tested with all plugins deactivated.

Have you tried replicating the bug using a default theme e.g. Twenty Twenty?

  • I have tested with a default theme.

Description

Can't create menu using "add all pages" option.

Step-by-step reproduction instructions

  1. Navigation screen, create new menu
  2. choose "add all pages"
  3. set a location for the menu
  4. save
  5. go to front end and verify menu doesn't display

Expected Behavior

Expected menu to show on front end.

Current Behavior

Menu doesn't show on front end.

Screenshots or screen recording (optional)

No response

Code snippet (optional)

No response

WordPress Information

No response

Gutenberg Information

No response

What browsers are you seeing the problem on?

No response

Device Information

No response

Operating System Information

No response

@tellthemachines tellthemachines self-assigned this Aug 11, 2021
@tellthemachines tellthemachines added [Block] Page List Affects the Page List Block [Feature] Navigation Screen [Type] Bug An existing feature does not function as intended labels Aug 11, 2021
@tellthemachines tellthemachines added this to Inbox in Navigation editor via automation Aug 11, 2021
@talldan
Copy link
Contributor

talldan commented Aug 11, 2021

So basically the Page List block isn't supposed to be supported by default (unless the theme opts in to supporting more block types), since it's not backwards compatible with how classic menu items work. It already can't be added via an appender.

I think this issue is a bit bigger than just the nav screen too. In other editors it's possible for the Page List block to be unregistered, but because this feature is hard coded into the nav block's placeholder, Page Lists can still be added.

@talldan talldan added the [Block] Navigation Affects the Navigation Block label Aug 11, 2021
@tellthemachines tellthemachines changed the title Add all pages option doesn't work in Navigation screen<title> Add all pages option doesn't work in Navigation screen Aug 11, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 6, 2021
Navigation editor automation moved this from Inbox to Done Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants