Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing issues in the mobile version of the Navigation editor screen #34032

Closed
3 tasks done
Tracked by #29102
javierarce opened this issue Aug 12, 2021 · 5 comments
Closed
3 tasks done
Tracked by #29102
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@javierarce
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Have you tried deactivating all plugins except Gutenberg?

  • I have tested with all plugins deactivated.

Have you tried replicating the bug using a default theme e.g. Twenty Twenty?

  • I have tested with a default theme.

Description

There are a couple of minor issues in the mobile version of the menu editor with the spacing between elements. Plus, an empty toolbar appears on top of the menu or placeholder.

Step-by-step reproduction instructions

Visit the editor with a small device or open the mobile view.

Expected Behavior

The menu should have some spacing on top, and the toolbar shouldn't be visible if it's empty.

Current Behavior

See description & screenshots.

Screenshots or screen recording (optional)

image

image

Code snippet (optional)

No response

WordPress Information

WordPress version: 5.8

Gutenberg Information

Gutenberg version: 11.2.1

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

Device Information

No response

Operating System Information

macOs Big Sur (11.5.1)

@javierarce javierarce added [Type] Bug An existing feature does not function as intended [Feature] Navigation Screen labels Aug 12, 2021
@talldan talldan added this to Inbox in Navigation editor via automation Aug 23, 2021
@getdave getdave changed the title Navigation screen: spacing issues in the mobile version Fix spacing issues in the mobile version of the Navigation editor screen Aug 25, 2021
@talldan talldan moved this from Inbox to Blocked in Navigation editor Aug 26, 2021
@talldan talldan moved this from Blocked to Needs dev in Navigation editor Aug 26, 2021
@vcanales
Copy link
Member

vcanales commented Sep 8, 2021

and the toolbar shouldn't be visible if it's empty.

Hi @javierarce — do you mean by this that if the Navigation menu hasn't been selected, the empty toolbar container shouldn't be shown? I interpret this part of the issue like this:

Selected Unselected
image Screen Shot 2021-09-08 at 12 57 18

@vcanales vcanales self-assigned this Sep 8, 2021
@javierarce
Copy link
Contributor Author

Hi @javierarce — do you mean by this that if the Navigation menu hasn't been selected, the empty toolbar container shouldn't be shown? I interpret this part of the issue like this:

@vcanales yes, exactly, that's the issue

@Mamaduka
Copy link
Member

Hi, @vcanales

I just wanted to check if you have availability to work on this fix? Otherwise, I'm happy to take over.

@vcanales
Copy link
Member

I just wanted to check if you have availability to work on this fix? Otherwise, I'm happy to take over.

I'm checking this out now, but I'll let you know if anything changes :)

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 23, 2021
@ndiego
Copy link
Member

ndiego commented Jul 26, 2022

Since the Navigation Editor experiment is no longer being worked on and was removed, I am going to close this issue.

@ndiego ndiego closed this as completed Jul 26, 2022
Navigation editor automation moved this from Needs dev to Done Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants